Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT Use null safe operator and default to 1 page #10696

Merged
merged 1 commit into from
Feb 20, 2023
Merged

MNT Use null safe operator and default to 1 page #10696

merged 1 commit into from
Feb 20, 2023

Conversation

michalkleiner
Copy link
Contributor

Alternative approach to #10695 using null safe operator and null coalesce for the default value.

@michalkleiner michalkleiner mentioned this pull request Feb 20, 2023
Merged
GuySartorelli
GuySartorelli approved these changes Feb 20, 2023
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh neat, I didn't think php had a null safe operator. Looks good to me, merge on green.

@michalkleiner michalkleiner merged commit bddad3a into silverstripe:5.0 Feb 20, 2023
@michalkleiner michalkleiner deleted the pulls/10694-pagination-null-safe branch February 20, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michalkleiner @GuySartorelli